Skip to content
Success

Changes

Summary

  1. TiCDC: Update TiCDC presubmit jobs to always run before merge for builds (commit: d59e744) (details)
Commit d59e744a35b576ab75f73d7f03794ada3490388d by noreply
TiCDC: Update TiCDC presubmit jobs to always run before merge for builds and checks (#4107)

## Summary

This PR modifies the Prow job configurations for TiCDC's presubmit
pipelines to ensure that build and check jobs run consistently before
merging, even when changes are limited to specific file patterns. The
changes also improve the trigger commands for integration test jobs to
support more intuitive aliases.

## Changes

- **Updated `pull-build-next-gen` job in
`latest-presubmits-next-gen.yaml`:**
- Commented out the `skip_if_only_changed` rule to disable automatic
skipping.
  - Added `run_before_merge: true` to enforce execution before merging.

- **Updated `pull-build` and `pull-check` jobs in
`latest-presubmits.yaml`:**
  - Commented out the `skip_if_only_changed` rule for both jobs.
- Added `run_before_merge: true` to both jobs to ensure they run before
merge.

- **Enhanced trigger commands for integration test jobs:**
- Modified the `trigger` regex patterns for all integration test jobs
(`pull-cdc-mysql-integration-light`, `pull-cdc-mysql-integration-heavy`,
`pull-cdc-kafka-integration-light`, `pull-cdc-kafka-integration-heavy`,
`pull-cdc-pulsar-integration-light`,
`pull-cdc-storage-integration-light`,
`pull-cdc-storage-integration-heavy`) to support shorter aliases
(`light`, `heavy`, `all`) in addition to the full job names. This makes
it easier to trigger these jobs via PR comments.

## Impact

- The `pull-build`, `pull-check`, and `pull-build-next-gen` jobs will
now run on all PRs targeting the specified branches (`master`,
`release-8.5`, etc.), regardless of the types of files changed. This
ensures consistent validation and reduces the risk of introducing
undetected issues into the codebase.
- The updated trigger patterns provide more flexibility and convenience
when manually running integration tests, aligning with common usage
patterns.

## Closed Issues

- Resolves the requirement to run build and check jobs before merging,
even for PRs that only change documentation or non-code files.

---------

Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
(commit: d59e744)
The file was modifiedprow-jobs/pingcap/ticdc/latest-presubmits.yaml (diff)
The file was modifiedprow-jobs/pingcap/ticdc/latest-presubmits-next-gen.yaml (diff)