Skip to content
Success

Changes

Summary

  1. fix(error-log-review): no required pr complete approved (#3872) (commit: eb8212b) (details)
Commit eb8212b575c315a2d127ec71cc5a653bc4cba54f by noreply
fix(error-log-review): no required pr complete approved (#3872)

The current implementation only extracts approvers from ti-chi-bot
comments that start with `[APPROVALNOTIFIER] This PR is **APPROVED**`.
However, ti-chi-bot also posts comments with `[APPROVALNOTIFIER] This PR
is **NOT APPROVED**` when a PR has received some approvals but is still
waiting for additional required approvers.

These "NOT APPROVED" comments still contain the list of users who have
already approved the PR, but they were being ignored by the current
code.


This change aligns with the principle that **error log review approval
should be independent of general PR approval**. A PR may have received
approval from authorized log reviewers even if it's still waiting for
other required approvals. The tool should recognize these log-specific
approvals regardless of the overall PR approval status.
(commit: eb8212b)
The file was modifiedtools/error-log-review/github.go (diff)